Improve Java comment filtering#80
Open
Vladyslav-Kuksiuk wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves embedding/commentfilter so comment stripping is more language-accurate, notably by teaching the marker-based filter to treat Java """ text blocks as multi-line literals (so // and /* ... */ inside the text block are preserved when comments="none").
Changes:
- Extend
MarkerCommentFilterto track multi-line “text block” literals (e.g., Java""") and skip comment scanning while inside them. - Add dedicated comment filters for Kotlin (nested block comments + raw
"""strings with${...}interpolation) and Visual Basic (apostrophe / doc /REMcomments). - Add regression tests covering Java text blocks, Kotlin raw strings/interpolation, and Visual Basic comment forms.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| embedding/commentfilter/marker_comment_filter.go | Adds text-block state tracking and scanning helpers to avoid stripping comment markers inside configured multi-line literals. |
| embedding/commentfilter/config.go | Registers Java """ as a text-block delimiter; wires Kotlin/VB extensions to their new filters. |
| embedding/commentfilter/kotlin_filter.go | Implements Kotlin-aware comment filtering (nested block comments, raw strings, interpolation). |
| embedding/commentfilter/visual_basic_filter.go | Implements Visual Basic-aware comment filtering (doc ''', apostrophe, and REM). |
| embedding/commentfilter/filter_test.go | Adds/extends tests for Java text blocks, Kotlin raw strings/interpolation, and Visual Basic comment behavior. |
…ent-filtering' into improve-java-comment-filtering
Oleg-Melnik
approved these changes
Jul 3, 2026
MykytaPimonovTD
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves Java comment filtering.
Resolves this issue